From 1c294e1ce42ee4bd7396de01353f295b8b843547 Mon Sep 17 00:00:00 2001 From: Keith Edmunds Date: Sat, 18 Feb 2023 18:11:19 +0000 Subject: [PATCH] Only send exception mails from production environment --- app/log.py | 2 +- app/musicmuster.py | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/log.py b/app/log.py index fd0ed5f..80e95b2 100644 --- a/app/log.py +++ b/app/log.py @@ -76,7 +76,7 @@ def log_uncaught_exceptions(_ex_cls, ex, tb): logging.critical(''.join(traceback.format_tb(tb))) print("\033[1;37;40m") print(stackprinter.format(ex, style="darkbg2", add_summary=True)) - if os.environ["MM_ENV"] != "DEVELOPMENT": + if os.environ["MM_ENV"] == "PRODUCTION": msg = stackprinter.format(ex) send_mail(Config.ERRORS_TO, Config.ERRORS_FROM, "Exception from musicmuster", msg) diff --git a/app/musicmuster.py b/app/musicmuster.py index cce7763..df01f68 100755 --- a/app/musicmuster.py +++ b/app/musicmuster.py @@ -3,6 +3,7 @@ from log import log from os.path import basename import argparse +import os import stackprinter # type: ignore import subprocess import sys @@ -1965,11 +1966,12 @@ if __name__ == "__main__": engine.dispose() sys.exit(status) except Exception as exc: - from helpers import send_mail + if os.environ["MM_ENV"] == "PRODUCTION": + from helpers import send_mail - msg = stackprinter.format(exc) - send_mail(Config.ERRORS_TO, Config.ERRORS_FROM, - "Exception from musicmuster", msg) + msg = stackprinter.format(exc) + send_mail(Config.ERRORS_TO, Config.ERRORS_FROM, + "Exception from musicmuster", msg) print("\033[1;31;47mUnhandled exception starts") stackprinter.show(style="darkbg")