Change row to row_number

This commit is contained in:
Keith Edmunds 2023-03-12 16:22:59 +00:00
parent 4094b63f44
commit 669125794f

View File

@ -527,19 +527,19 @@ class PlaylistTab(QTableWidget):
Insert passed playlist row (plr) into playlist tab. Insert passed playlist row (plr) into playlist tab.
""" """
row = plr.row_number row_number = plr.row_number
bold = True bold = True
self.insertRow(row) self.insertRow(row_number)
_ = self._set_row_plr_id(row, plr.id) _ = self._set_row_plr_id(row_number, plr.id)
if plr.track: if plr.track:
self._update_row_track_info(session, row, plr.track) self._update_row_track_info(session, row_number, plr.track)
if played: if played:
bold = False bold = False
_ = self._set_row_userdata(row, self.PLAYED, True) _ = self._set_row_userdata(row_number, self.PLAYED, True)
if plr.note is None: if plr.note is None:
plr.note = "" plr.note = ""
self._set_row_note_text(session, row, plr.note) self._set_row_note_text(session, row_number, plr.note)
else: else:
# This is a section header so it must have note text # This is a section header so it must have note text
if plr.note is None: if plr.note is None:
@ -549,14 +549,14 @@ class PlaylistTab(QTableWidget):
return return
# Use one QTableWidgetItem to span all columns from column 1 # Use one QTableWidgetItem to span all columns from column 1
self._set_row_header_text(session, row, plr.note) self._set_row_header_text(session, row_number, plr.note)
self.setSpan(row, HEADER_NOTES_COLUMN, 1, len(columns) - 1) self.setSpan(row_number, HEADER_NOTES_COLUMN, 1, len(columns) - 1)
# Save (or clear) track_id # Save (or clear) track_id
_ = self._set_row_track_id(row, 0) _ = self._set_row_track_id(row_number, 0)
# Set bold as needed # Set bold as needed
self._set_row_bold(row, bold) self._set_row_bold(row_number, bold)
def insert_track(self, session: scoped_session, track: Tracks, def insert_track(self, session: scoped_session, track: Tracks,
note: str = "", repaint: bool = True) -> None: note: str = "", repaint: bool = True) -> None:
@ -648,7 +648,7 @@ class PlaylistTab(QTableWidget):
# Update start/stop times # Update start/stop times
self._update_start_end_times() self._update_start_end_times()
# Update hidden tracks* # Update hidden tracks
QTimer.singleShot(Config.HIDE_AFTER_PLAYING_OFFSET, QTimer.singleShot(Config.HIDE_AFTER_PLAYING_OFFSET,
self.hide_or_show_played_tracks) self.hide_or_show_played_tracks)
@ -711,11 +711,11 @@ class PlaylistTab(QTableWidget):
Unmark next track Unmark next track
""" """
row = self._get_next_track_row_number() row_number = self._get_next_track_row_number()
if not row: if not row_number:
return return
self.musicmuster.clear_next() self.musicmuster.clear_next()
self._set_row_colour_default(row) self._set_row_colour_default(row_number)
self.clear_selection() self.clear_selection()
def save_playlist(self, session: scoped_session) -> None: def save_playlist(self, session: scoped_session) -> None:
@ -727,11 +727,11 @@ class PlaylistTab(QTableWidget):
""" """
# Ensure all row plrs have correct row number and playlist_id # Ensure all row plrs have correct row number and playlist_id
for row in range(self.rowCount()): for row_number in range(self.rowCount()):
plr = self._get_row_plr(session, row) plr = self._get_row_plr(session, row_number)
if not plr: if not plr:
continue continue
plr.row_number = row plr.row_number = row_number
plr.playlist_id = self.playlist_id plr.playlist_id = self.playlist_id
# Any rows in the database for this playlist that has a row # Any rows in the database for this playlist that has a row
@ -791,27 +791,27 @@ class PlaylistTab(QTableWidget):
return return
# select first row if none selected # select first row if none selected
if len(selected_rows) == 0: if len(selected_rows) == 0:
row = 0 row_number = 0
else: else:
row = selected_rows[0] + 1 row_number = selected_rows[0] + 1
if row >= self.rowCount(): if row_number >= self.rowCount():
row = 0 row_number = 0
# Don't select section headers # Don't select section headers
wrapped = False wrapped = False
track_id = self._get_row_track_id(row) track_id = self._get_row_track_id(row_number)
while not track_id: while not track_id:
row += 1 row_number += 1
if row >= self.rowCount(): if row_number >= self.rowCount():
if wrapped: if wrapped:
# we're already wrapped once, so there are no # we're already wrapped once, so there are no
# non-headers # non-headers
return return
row = 0 row_number = 0
wrapped = True wrapped = True
track_id = self._get_row_track_id(row) track_id = self._get_row_track_id(row_number)
self.selectRow(row) self.selectRow(row_number)
def select_previous_row(self) -> None: def select_previous_row(self) -> None:
""" """
@ -826,35 +826,35 @@ class PlaylistTab(QTableWidget):
# select last row if none selected # select last row if none selected
last_row = self.rowCount() - 1 last_row = self.rowCount() - 1
if len(selected_rows) == 0: if len(selected_rows) == 0:
row = last_row row_number = last_row
else: else:
row = selected_rows[0] - 1 row_number = selected_rows[0] - 1
if row < 0: if row_number < 0:
row = last_row row_number = last_row
# Don't select section headers # Don't select section headers
wrapped = False wrapped = False
track_id = self._get_row_track_id(row) track_id = self._get_row_track_id(row_number)
while not track_id: while not track_id:
row -= 1 row_number -= 1
if row < 0: if row_number < 0:
if wrapped: if wrapped:
# we're already wrapped once, so there are no # we're already wrapped once, so there are no
# non-notes # non-notes
return return
row = last_row row_number = last_row
wrapped = True wrapped = True
track_id = self._get_row_track_id(row) track_id = self._get_row_track_id(row_number)
self.selectRow(row) self.selectRow(row_number)
def set_selected_as_next(self) -> None: def set_selected_as_next(self) -> None:
"""Sets the select track as next to play""" """Sets the select track as next to play"""
row = self._get_selected_row() row_number = self._get_selected_row()
if row is not None: if row_number is not None:
with Session() as session: with Session() as session:
self._set_next(session, row) self._set_next(session, row_number)
def tab_visible(self) -> None: def tab_visible(self) -> None:
"""Called when tab becomes visible""" """Called when tab becomes visible"""
@ -867,12 +867,13 @@ class PlaylistTab(QTableWidget):
# # ########## Internally called functions ########## # # ########## Internally called functions ##########
def _add_track(self, row: int) -> None: def _add_track(self, row_number: int) -> None:
"""Add a track to a section header making it a normal track row""" """Add a track to a section header making it a normal track row"""
print(f"_add_track({row_number=})")
with Session() as session: with Session() as session:
# Add track to playlist row # Add track to playlist row
plr = self._get_row_plr(session, row) plr = self._get_row_plr(session, row_number)
if not plr: if not plr:
return return