kae/musicmuster
1
0
Fork 0
Code Issues 28 Pull Requests Projects Releases 1 Activity

Clean up handling of separators in dynamic menu

Browse Source
This commit is contained in:
Keith Edmunds 2025-02-27 08:13:29 +00:00
parent 82e707a6f6
commit 90d72464cb
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/musicmuster.py
View File

@ -847,7 +847,7 @@ class Window(QMainWindow):
items = getattr(self, f"get_{key}_items")() items = getattr(self, f"get_{key}_items")()
for item in items: for item in items:
# Check for separator # Check for separator
if "separator" in item and item["separator"] == "separator": if "separator" in item and item["separator"]:
submenu.addSeparator() submenu.addSeparator()
continue continue
action = QAction(item["text"], self) action = QAction(item["text"], self)
@ -865,7 +865,7 @@ class Window(QMainWindow):
def get_new_playlist_dynamic_submenu_items( def get_new_playlist_dynamic_submenu_items(
self, self,
) -> list[dict[str, str | tuple[Session, int]]]: ) -> list[dict[str, str | tuple[Session, int] | bool]]:
""" """
Return dynamically generated menu items, in this case Return dynamically generated menu items, in this case
templates marked as favourite from which to generate a templates marked as favourite from which to generate a
@ -876,14 +876,14 @@ class Window(QMainWindow):
""" """
with db.Session() as session: with db.Session() as session:
submenu_items: list[dict[str, str | tuple[Session, int]]] = [ submenu_items: list[dict[str, str | tuple[Session, int] | bool]] = [
{ {
"text": "Show all", "text": "Show all",
"handler": "create_playlist_from_template", "handler": "create_playlist_from_template",
"args": (session, 0), "args": (session, 0),
}, },
{ {
"separator": "separator", "separator": True,
} }
] ]
templates = Playlists.get_favourite_templates(session) templates = Playlists.get_favourite_templates(session)