kae/musicmuster
1
0
Fork 0
Code Issues 28 Pull Requests Projects Releases 1 Activity

Fix potential bug in get_selected_playlistrows()

Browse Source 
It was possible for the returned list to have embedded None objects
This commit is contained in:
Keith Edmunds 2023-02-18 10:43:38 +00:00
parent c93f24970f
commit a41aea2d36
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/playlists.py
View File

@ -594,8 +594,8 @@ class PlaylistTab(QTableWidget):
return [self._get_playlistrow_id(a) for a in self._get_selected_rows()] return [self._get_playlistrow_id(a) for a in self._get_selected_rows()]
def get_selected_playlistrows(self, def get_selected_playlistrows(
session: scoped_session) -> Optional[List]: self, session: scoped_session) -> Optional[List[PlaylistRows]]:
""" """
Return a list of PlaylistRows of the selected rows Return a list of PlaylistRows of the selected rows
""" """
@ -603,7 +603,9 @@ class PlaylistTab(QTableWidget):
plr_ids = self.get_selected_playlistrow_ids() plr_ids = self.get_selected_playlistrow_ids()
if not plr_ids: if not plr_ids:
return None return None
return [session.get(PlaylistRows, a) for a in plr_ids] plrs = [session.get(PlaylistRows, a) for a in plr_ids]
return [plr for plr in plrs if plr is not None]
def insert_header(self, session: scoped_session, note: str, def insert_header(self, session: scoped_session, note: str,
repaint: bool = True) -> None: repaint: bool = True) -> None: