kae/musicmuster
1
0
Fork 0
Code Issues 28 Pull Requests Projects Releases 1 Activity

Don't accept unreadable track into _TrackManager

Browse Source
This commit is contained in:
Keith Edmunds 2024-06-03 19:06:00 +01:00
parent 2f32f2e914
commit e884201df4
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/musicmuster.py
View File

@ -1075,11 +1075,15 @@ class Window(QMainWindow, Ui_MainWindow):
self.btnPreview.setChecked(False) self.btnPreview.setChecked(False)
return return
with db.Session() as session: try:
self.preview_track_manager = PreviewTrackManager( with db.Session() as session:
session=session, track_id=track_id, row_number=row_number self.preview_track_manager = PreviewTrackManager(
) session=session, track_id=track_id, row_number=row_number
self.preview_track_manager.play() )
self.preview_track_manager.play()
except ValueError as e:
log.error(f"Error creating PreviewTrackManager({str(e)})")
return
else: else:
if self.preview_track_manager: if self.preview_track_manager:

2
app/playlistmodel.py
View File

@ -1270,7 +1270,7 @@ class PlaylistModel(QAbstractTableModel):
track_sequence.next = MainTrackManager(session, prd.plrid) track_sequence.next = MainTrackManager(session, prd.plrid)
self.invalidate_row(row_number) self.invalidate_row(row_number)
except ValueError as e: except ValueError as e:
log.error(f"Error creating PlaylistTrack({prd=}): ({str(e)})") log.error(f"Error creating MainTrackManager({prd=}): ({str(e)})")
return return
self.signals.search_wikipedia_signal.emit( self.signals.search_wikipedia_signal.emit(

4
app/trackmanager.py
View File

@ -381,6 +381,10 @@ class _TrackManager:
self.row_number = row_number self.row_number = row_number
self.preview_player = preview_player self.preview_player = preview_player
# Check file readable
if file_is_unreadable(track.path):
raise ValueError(f"_TrackManager.__init__: {track.path=} unreadable")
self.artist = track.artist self.artist = track.artist
self.bitrate = track.bitrate self.bitrate = track.bitrate
self.duration = track.duration self.duration = track.duration