Compare commits

..

No commits in common. "af6e0f69be51effb881a3dafb858bf3dde1ca0be" and "b0278b92b046b6a912212d711b8af727b27d6c7e" have entirely different histories.

3 changed files with 54 additions and 61 deletions

View File

@ -227,11 +227,8 @@ class Window(QMainWindow, Ui_MainWindow):
self.move_source_model: Optional[PlaylistProxyModel] = None self.move_source_model: Optional[PlaylistProxyModel] = None
self.audacity_file_path: Optional[str] = None self.audacity_file_path: Optional[str] = None
# Initialise Audacity access # Initialise Audacity access
try: self.audacity_client = pipeclient.PipeClient()
self.audacity_client = pipeclient.PipeClient() log.info(f"{hex(id(self.audacity_client))=}")
log.info(f"{hex(id(self.audacity_client))=}")
except RuntimeError as e:
log.error(f"Unable to initialise Audacity: {str(e)}")
if Config.CARTS_HIDE: if Config.CARTS_HIDE:
self.cartsWidget.hide() self.cartsWidget.hide()
@ -789,8 +786,6 @@ class Window(QMainWindow, Ui_MainWindow):
self.hide_played_tracks = True self.hide_played_tracks = True
self.active_proxy_model().hide_played_tracks(True) self.active_proxy_model().hide_played_tracks(True)
self.btnHidePlayed.setText("Show played") self.btnHidePlayed.setText("Show played")
# Reset row heights
self.active_tab().resizeRowsToContents()
def import_track(self) -> None: def import_track(self) -> None:
"""Import track file""" """Import track file"""
@ -1127,20 +1122,20 @@ class Window(QMainWindow, Ui_MainWindow):
if not track_sequence.now.path: if not track_sequence.now.path:
log.error("No path for next track") log.error("No path for next track")
return return
self.music.play(track_sequence.now.path, position)
# Note that track is playing # Notify model
track_sequence.now.start() self.active_proxy_model().current_track_started()
# Note that track is now playing
self.playing = True self.playing = True
# Disable play next controls # Disable play next controls
self.disable_play_next_controls() self.disable_play_next_controls()
# Notify model
self.active_proxy_model().current_track_started()
# Update headers # Update headers
self.update_headers() self.update_headers()
track_sequence.now.start()
self.music.play(track_sequence.now.path, position)
# Ensure 100% volume # Ensure 100% volume
# For as-yet unknown reasons. sometimes the volume gets # For as-yet unknown reasons. sometimes the volume gets
@ -1493,7 +1488,7 @@ class Window(QMainWindow, Ui_MainWindow):
tab = self.active_tab() tab = self.active_tab()
if tab: if tab:
QTimer.singleShot(300, tab.resizeRowsToContents) tab.resizeRowsToContents()
def tick_10ms(self) -> None: def tick_10ms(self) -> None:
""" """

View File

@ -81,7 +81,7 @@ import argparse
if sys.version_info[0] < 3: if sys.version_info[0] < 3:
raise RuntimeError('PipeClient Error: Python 3.x required') sys.exit('PipeClient Error: Python 3.x required')
# Platform specific constants # Platform specific constants
if sys.platform == 'win32': if sys.platform == 'win32':
@ -156,7 +156,7 @@ class PipeClient():
# Allow a little time for connection to be made. # Allow a little time for connection to be made.
time.sleep(0.1) time.sleep(0.1)
if not self._write_pipe: if not self._write_pipe:
raise RuntimeError('PipeClientError: Write pipe cannot be opened.') sys.exit('PipeClientError: Write pipe cannot be opened.')
def _write_pipe_open(self) -> None: def _write_pipe_open(self) -> None:
"""Open _write_pipe.""" """Open _write_pipe."""
@ -187,7 +187,7 @@ class PipeClient():
self._write_pipe.write(command + EOL) self._write_pipe.write(command + EOL)
# Check that read pipe is alive # Check that read pipe is alive
if PipeClient.reader_pipe_broken.is_set(): if PipeClient.reader_pipe_broken.is_set():
raise RuntimeError('PipeClient: Read-pipe error.') sys.exit('PipeClient: Read-pipe error.')
try: try:
self._write_pipe.flush() self._write_pipe.flush()
if self.timer: if self.timer:
@ -196,7 +196,7 @@ class PipeClient():
PipeClient.reply_ready.clear() PipeClient.reply_ready.clear()
except IOError as err: except IOError as err:
if err.errno == errno.EPIPE: if err.errno == errno.EPIPE:
raise RuntimeError('PipeClient: Write-pipe error.') sys.exit('PipeClient: Write-pipe error.')
else: else:
raise raise

View File

@ -68,8 +68,6 @@ class PlaylistRowData:
self.played = False self.played = False
self.start_gap: Optional[int] = None self.start_gap: Optional[int] = None
self.title: str = "" self.title: str = ""
self.start_time: Optional[datetime] = None
self.end_time: Optional[datetime] = None
self.plrid: int = plr.id self.plrid: int = plr.id
self.plr_rownum: int = plr.plr_rownum self.plr_rownum: int = plr.plr_rownum
@ -95,6 +93,12 @@ class PlaylistRowData:
) )
@dataclass
class StartEndTimes:
start_time: Optional[datetime] = None
end_time: Optional[datetime] = None
class PlaylistModel(QAbstractTableModel): class PlaylistModel(QAbstractTableModel):
""" """
The Playlist Model The Playlist Model
@ -123,6 +127,7 @@ class PlaylistModel(QAbstractTableModel):
super().__init__(*args, **kwargs) super().__init__(*args, **kwargs)
self.playlist_rows: dict[int, PlaylistRowData] = {} self.playlist_rows: dict[int, PlaylistRowData] = {}
self.start_end_times: dict[int, StartEndTimes] = {}
self.signals = MusicMusterSignals() self.signals = MusicMusterSignals()
self.played_tracks_hidden = False self.played_tracks_hidden = False
@ -254,7 +259,6 @@ class PlaylistModel(QAbstractTableModel):
""" """
row_number = track_sequence.now.plr_rownum row_number = track_sequence.now.plr_rownum
prd = self.playlist_rows[row_number]
# Sanity check # Sanity check
if not track_sequence.now.track_id: if not track_sequence.now.track_id:
@ -285,8 +289,8 @@ class PlaylistModel(QAbstractTableModel):
log.error(f"Can't retrieve plr, {track_sequence.now.plr_id=}") log.error(f"Can't retrieve plr, {track_sequence.now.plr_id=}")
# Update track times # Update track times
prd.start_time = track_sequence.now.start_time self.start_end_times[row_number].start_time = track_sequence.now.start_time
prd.end_time = track_sequence.now.end_time self.start_end_times[row_number].end_time = track_sequence.now.end_time
# Update colour and times for current row # Update colour and times for current row
self.invalidate_row(row_number) self.invalidate_row(row_number)
@ -404,15 +408,17 @@ class PlaylistModel(QAbstractTableModel):
return QVariant() return QVariant()
if column == Col.START_TIME.value: if column == Col.START_TIME.value:
start_time = prd.start_time if row in self.start_end_times:
if start_time: start_time = self.start_end_times[row].start_time
return QVariant(start_time.strftime(Config.TRACK_TIME_FORMAT)) if start_time:
return QVariant(start_time.strftime(Config.TRACK_TIME_FORMAT))
return QVariant() return QVariant()
if column == Col.END_TIME.value: if column == Col.END_TIME.value:
end_time = prd.end_time if row in self.start_end_times:
if end_time: end_time = self.start_end_times[row].end_time
return QVariant(end_time.strftime(Config.TRACK_TIME_FORMAT)) if end_time:
return QVariant(end_time.strftime(Config.TRACK_TIME_FORMAT))
return QVariant() return QVariant()
dispatch_table = { dispatch_table = {
@ -1321,15 +1327,15 @@ class PlaylistModel(QAbstractTableModel):
update_rows: List[int] = [] update_rows: List[int] = []
for row_number in range(len(self.playlist_rows)): for row_number in range(len(self.playlist_rows)):
stend = self.start_end_times[row_number] = StartEndTimes()
prd = self.playlist_rows[row_number] prd = self.playlist_rows[row_number]
# Reset start_time if this is the current row # Reset start_time if this is the current row
if row_number == track_sequence.now.plr_rownum: if row_number == track_sequence.now.plr_rownum:
prd.start_time = track_sequence.now.start_time stend.start_time = track_sequence.now.start_time
prd.end_time = track_sequence.now.end_time stend.end_time = track_sequence.now.end_time
update_rows.append(row_number)
if not next_start_time: if not next_start_time:
next_start_time = prd.end_time next_start_time = stend.end_time
continue continue
# Set start time for next row if we have a current track # Set start time for next row if we have a current track
@ -1337,9 +1343,9 @@ class PlaylistModel(QAbstractTableModel):
row_number == track_sequence.next.plr_rownum row_number == track_sequence.next.plr_rownum
and track_sequence.now.end_time and track_sequence.now.end_time
): ):
prd.start_time = track_sequence.now.end_time stend.start_time = track_sequence.now.end_time
prd.end_time = prd.start_time + timedelta(milliseconds=prd.duration) stend.end_time = stend.start_time + timedelta(milliseconds=prd.duration)
next_start_time = prd.end_time next_start_time = stend.end_time
update_rows.append(row_number) update_rows.append(row_number)
continue continue
@ -1356,39 +1362,31 @@ class PlaylistModel(QAbstractTableModel):
< row_number < row_number
< track_sequence.next.plr_rownum < track_sequence.next.plr_rownum
): ):
prd.start_time = None
prd.end_time = None
update_rows.append(row_number) update_rows.append(row_number)
continue continue
# Reset start time if timing in header # Reset start time if timing in header or at current track
if self.is_header_row(row_number): if self.is_header_row(row_number):
header_time = get_embedded_time(prd.note) header_time = get_embedded_time(prd.note)
if header_time: if header_time:
next_start_time = header_time next_start_time = header_time
continue else:
# This is an unplayed track
# Don't schedule unplayable tracks
if file_is_unreadable(prd.path):
continue
# This is an unplayed track # Set start/end if we have a start time
# Don't schedule unplayable tracks if next_start_time is None:
if file_is_unreadable(prd.path): continue
continue if stend.start_time != next_start_time:
stend.start_time = next_start_time
# Set start/end if we have a start time update_rows.append(row_number)
if next_start_time is None: next_start_time += timedelta(
continue milliseconds=self.playlist_rows[row_number].duration
)
# Update start time of this row if it's incorrect if stend.end_time != next_start_time:
if prd.start_time != next_start_time: stend.end_time = next_start_time
prd.start_time = next_start_time
update_rows.append(row_number)
# Calculate next start time
next_start_time += timedelta(milliseconds=prd.duration)
# Update end time of this row if it's incorrect
if prd.end_time != next_start_time:
prd.end_time = next_start_time
if row_number not in update_rows:
update_rows.append(row_number) update_rows.append(row_number)
# Update start/stop times of rows that have changed # Update start/stop times of rows that have changed